Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergable Libraries are unsupported #609

Closed
abarisain opened this issue May 20, 2024 · 8 comments · Fixed by #612
Closed

Mergable Libraries are unsupported #609

abarisain opened this issue May 20, 2024 · 8 comments · Fixed by #612

Comments

@abarisain
Copy link

Hello!

Apple has introduced mergable libraries with Xcode 15.

As I understand them, they are dynamic frameworks but come with additional metadata allowing them to be statically merged.

It also comes with a new load command, LC_ATOM_INFO (code 0x36) https://github.com/llvm/llvm-project/blob/82c5d350d200ccc5365d40eac187b9ec967af727/llvm/include/llvm/BinaryFormat/MachO.def#L80

This library doesn't understand this code and fails parsing the binary.
I'm not sure what you could to with it or what you could expose, I just thought I'd let you know as it breaks parsing altogether.

Have a nice day,
Arnaud

PS: I noticed this issue via CocoaPods, which still uses version 2.5 of this library. So, I don't think there's a need to rush this.

@woodruffw
Copy link
Member

Thanks for reporting this @abarisain! We've merged the fix, and I can do a release if it'd help. But yeah, CocoaPods should probably upgrade first 🙂

@abarisain
Copy link
Author

Thank you for the fast fix!

I don't think there is any rush to cut a release.

@goncg007
Copy link

Doesn't Cocoapods need a release of Macho to fix the problem there?

@goncg007
Copy link

@woodruffw is it possible to release a version with this fix?

@woodruffw
Copy link
Member

They do, but they're currently on a pretty old version. I'm happy to do a new release in early June however (currently traveling).

@goncg007
Copy link

goncg007 commented May 28, 2024

yes please @woodruffw, and then I can create a PR in Cocoapods to update them and use your newest version.
Let me know when the version is out please. If there is a chance to do it sooner, that would help us a lot :)

@abarisain
Copy link
Author

Please ease up on the maintainer pressure here, we had literally 0 signal from cocoapods that they intend to update this library or merge your PR anytime soon.

Those things take time :)

@MikeMcQuaid
Copy link
Member

@goncg007 Would suggest the PR is opened first using a non-tagged version of this library to check that Cocoapods are willing to do this and it doesn't break anything on their end. Once Cocoapods are 👍🏻 and @woodruffw is ready: it could be tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants