fix(cli): use CliNodeResolver::resolve() for managed node_modules #23902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
May 20, 2024
dsherret
reviewed
May 21, 2024
nayeemrmn
commented
May 21, 2024
Comment on lines
+7217
to
+7220
| assert_eq!( | ||
| json!(diagnostics.all()), | ||
| json!([ | ||
| { |
There was a problem hiding this comment.
Verified that this fails on main
bartlomieju
pushed a commit
that referenced
this pull request
May 21, 2024
bartlomieju
pushed a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23895.
Fixes #23878.
This was a regression in #23764 caused by removing this code block: https://github.com/denoland/deno/pull/23764/files#diff-5edc220fbc0fc6aebb443d977875a955bcb1304beb56fefbebae42925824d49aL1111-L1121. I supposed this was handled by the
CliGraphResolver. This patch ensuresCliNodeResolver::node_resolve()is called inCliGraphResolver::resolve().Maybe this was broken inNot sure how to test this.deno checkas well but no errors are surfaced because it produces a bunch ofanytypes.