Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fixes animated frame timing #44622

Closed
wants to merge 1 commit into from
Closed

[iOS] Fixes animated frame timing #44622

wants to merge 1 commit into from

Conversation

zhongwuzw
Copy link
Contributor

Summary:

Fixes #44608 .

Changelog:

[IOS] [FIXED] - Fixes animated frame timing

Test Plan:

Example in #44608 .

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels May 20, 2024
cipolleschi
cipolleschi approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, thanks for working on this!

@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,542,765 +15
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,912,821 +13
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 06e37bb
Branch: main

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 29, 2024
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in 690df7a.

@github-actions GitHub Actions
Copy link

This pull request was successfully merged by @zhongwuzw in 690df7a.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image .gif frame timing off-by-one error in iOS
4 participants
@zhongwuzw @facebook-github-bot @analysis-bot @cipolleschi