Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-06] [HOLD on #4114/#17767] [$500] iOS - Chat - When moving to another line, the word and emoji are close to each other. #14445

Open
1 task done
kbecciv opened this issue Jan 20, 2023 · 64 comments · Fixed by Expensify/react-native-live-markdown#350 · May be fixed by facebook/react-native#44614
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jan 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with any account
  3. In the compose box enter message with have lengthier letters like (j) and emoji

Expected Result:

Text entered with letters and emojis on the next line must not be close to each other

Actual Result:

When moving to another line, the word and emoji are close to each other

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • iOS / native

Version Number: 1.2.57.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5904758_ios_2001_cherep.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ebb233eae82dffea
  • Upwork Job ID: 1622658479891505152
  • Last Price Increase: 2024-03-05
Issue OwnerCurrent Issue Owner: @twisterdotcom
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 24, 2023
@twisterdotcom
Copy link
Contributor

Sorry for the delay, I was getting my Android phone working as well to test it there too.

My first few of these, so taking the template from StackOverflowTeams: https://stackoverflowteams.com/c/expensify/questions/14418

  • The "bug" is actually a bug.
  • The bug is not a duplicate report of an existing GH
  • The bug is reproducible, following the reproduction steps.
  • The GH template is filled out as fully as possible
  • The GH was created by an Expensify employee or a QA tester.
  • The bug is an /App issue

So, as we can see from my checklist, I don't see this still occurring.

iOS v12-58.4

RPReplay_Final1674667829.MP4

Eugh, and my Android device still isn't working. Okay, in the meantime - I think this has self-resolved somehow. Could you confirm @kbecciv?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 25, 2023
@twisterdotcom
Copy link
Contributor

Okay, I tested this again today and I think this is a non-issue/resolved. Closing it.

@kbecciv
Copy link
Author

kbecciv commented Feb 4, 2023

@twisterdotcom Issue is still reproduced with build 1.2.64.3
Please type the message with lengthier letters like (j) and emoji, so you will be able to reproduce it.

repro ios 0302 (2)

@kbecciv kbecciv reopened this Feb 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 4, 2023
@twisterdotcom twisterdotcom added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 6, 2023
@MelvinBot
Copy link

Current assignee @twisterdotcom is eligible for the Bug assigner, not assigning anyone new.

@MelvinBot
Copy link

MelvinBot commented Feb 6, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@twisterdotcom
Copy link
Contributor

Okay, you're right? Yes, if it's a lower case letter than typically falls below the bottom line, it interferes ever so slightly with the next line, especially emoji. So q, j, g, y, and p I think:
IMG_A7E855E2C6FE-1

@melvin-bot melvin-bot bot removed the Overdue label Feb 6, 2023
@twisterdotcom twisterdotcom added External Added to denote the issue can be worked on by a contributor Overdue labels Feb 6, 2023
@melvin-bot melvin-bot bot unlocked this conversation Feb 6, 2023
@melvin-bot melvin-bot bot changed the title iOS - Chat - When moving to another line, the word and emoji are close to each other. [$1000] iOS - Chat - When moving to another line, the word and emoji are close to each other. Feb 6, 2023
@MelvinBot
Copy link

Job added to Upwork: https://www.upwork.com/jobs/~01ebb233eae82dffea

@MelvinBot
Copy link

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 6, 2023
@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

The BZ member will need to manually hire fabOnReact for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

@melvin-bot melvin-bot bot added the Overdue label May 9, 2024
@twisterdotcom
Copy link
Contributor

Bump on this @fabOnReact

@melvin-bot melvin-bot bot removed the Overdue label May 13, 2024
@fabOnReact
Copy link
Contributor

The BZ member will need to manually hire fabOnReact for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

I tried to apply for the Upwork job but it says that the job is no longer available.
I used this link https://www.upwork.com/jobs/~01ebb233eae82dffea
This is my Upwork profile https://www.upwork.com/freelancers/~01ae44247887fa908b?viewMode=1

Thanks

@twisterdotcom
Copy link
Contributor

Offer sent: https://www.upwork.com/nx/wm/offer/102318386.

You can accept, but I think we still want to ensure that #4114 or #17767 won't actually resolve it anyway, and that your solution will work after that.

@fabOnReact
Copy link
Contributor

fabOnReact commented May 17, 2024

Update 17th May 2024

@twisterdotcom I wanted to let you know that I accepted the offer.

You can accept, but I think we still want to ensure that #4114 or #17767 won't actually resolve it anyway, and that your solution will work after that.

I tested a solution for this issue. I will publish the Pull Request with the solution in a couple of days. Thanks.

@fabOnReact
Copy link
Contributor

fabOnReact commented May 21, 2024

Update 21st May 2024

I published 2 PRs Expensify/react-native-live-markdown#350 and facebook/react-native#44614 to fix this issue. I will follow up in a couple of days. Thanks

@fabOnReact
Copy link
Contributor

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels May 23, 2024
@fabOnReact
Copy link
Contributor

Update 23 May 2024

Moved PR #42454 to ready for review.

@fabOnReact
Copy link
Contributor

Update 28 May 2024

  • PR #42454 merged
  • I'll be away for 3 days for personal reasons (29, 30, 31st). I will restart working on Saturday 1st of June.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels May 30, 2024
@melvin-bot melvin-bot bot changed the title [HOLD on #4114/#17767] [$500] iOS - Chat - When moving to another line, the word and emoji are close to each other. [HOLD for payment 2024-06-06] [HOLD on #4114/#17767] [$500] iOS - Chat - When moving to another line, the word and emoji are close to each other. May 30, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 30, 2024
Copy link

melvin-bot bot commented May 30, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented May 30, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

  • @eVoloshchak requires payment through NewDot Manual Requests
  • @fabOnReact requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented May 30, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
  • [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@eVoloshchak] Determine if we should create a regression test for this bug.
  • [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@fabOnReact
Copy link
Contributor

fabOnReact commented Jun 1, 2024

Update 1st of June 2024

PR #42454 was reverted because there are issues with react-native-live-markdown. The issues seem to not be related to PR Expensify/react-native-live-markdown#350.

I will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
8 participants