-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add climate platform for tplink #117765
base: tplink_rewrite
Are you sure you want to change the base?
Add climate platform for tplink #117765
Conversation
Hey there @TheGardenMonkey, @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
5a633b5
to
bd05eb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR, I only have minor suggestions in addition to your TODO comments
98be5f9
to
6c598bc
Compare
This PR is part of the tplink rewrite series, to be merged into
tplink_rewrite
branch (see #111151).Proposed change
Add
climate
platform for tplink (builds on top of #117758).This is a an experimental PoC to see how thermostats could be integrated to homeassistant and how the API should look like.
In contrast to rest of the PRs in the rewrite series, this requires some more work before it's ready to go.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: