Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Calico manifest backward compatibility bug #11197

Closed
wants to merge 1 commit into from
Closed

Fix: Calico manifest backward compatibility bug #11197

wants to merge 1 commit into from

Conversation

hadi2f244
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:
There is a difference between calico v3.25.x and newer ones manifest that makes a cluster-role(calico-node) not to be backward compatible with older versions( calico_version < 3.26.x ).

Which issue(s) this PR fixes:

Fixes #11195

Special notes for your reviewer:

Check related issue on Calico repository also.

Does this PR introduce a user-facing change?:

None.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 15, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 15, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hadi2f244 / name: Hadi Azaddel (416574b)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @hadi2f244!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hadi2f244
Once this PR has been reviewed and has the lgtm label, please assign oomichi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @hadi2f244. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 15, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 15, 2024
@yankay
Copy link
Member

yankay commented May 16, 2024

HI @cyclinder
would you please help to review it.
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2024
@hadi2f244 hadi2f244 closed this May 16, 2024
@hadi2f244
Copy link
Author

As mentioned in the related Calico Issue manifests must not be merged. I will open new merge request for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian Awaiting requested review from mzaian

@yankay yankay Awaiting requested review from yankay

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubespray release-2.24 (v2.24.1) issue with calico version v3.25.2
3 participants
@hadi2f244 @k8s-ci-robot @yankay