Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar items vary in height #42877

Closed
kamilmielnik opened this issue May 20, 2024 · 0 comments · Fixed by #43585
Closed

Sidebar items vary in height #42877

kamilmielnik opened this issue May 20, 2024 · 0 comments · Fixed by #43585
Assignees
@npfitz
Labels
.Frontend Organization/ Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Team/AdminWebapp Admin and Webapp team Type:Bug Product defects
Milestone
0.50

Comments

@kamilmielnik
Copy link
Contributor

kamilmielnik commented May 20, 2024 •
edited

Describe the bug

image

To Reproduce

  1. Create a question visualized as a table and bookmark it
  2. Create a question visualized as a bar chart and bookmark it
  3. Inspect height of bookmark elements in the sidebar

Item representing 1st question is 33px high.
Item representing 2nd question is 29px high.

Expected behavior

Sidebar items should be of the same height

Information about your Metabase installation

master, 5d795be

Severity

P3
@kamilmielnik kamilmielnik added Type:Bug Product defects .Needs Triage Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Frontend .Team/AdminWebapp Admin and Webapp team Organization/ and removed .Needs Triage labels May 20, 2024
@npfitz npfitz self-assigned this Jun 3, 2024
@npfitz npfitz mentioned this issue Jun 4, 2024
Merged
@npfitz npfitz added this to the 0.50 milestone Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npfitz npfitz

Labels
.Frontend Organization/ Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Team/AdminWebapp Admin and Webapp team Type:Bug Product defects
Projects
None yet
Milestone
0.50
Development

Successfully merging a pull request may close this issue.

remove modified padding on ellipsifyed sidebar items metabase/metabase
2 participants
@npfitz @kamilmielnik