Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink / Reconsider / Revamp Babel presets #13149

Open
paulincai opened this issue May 20, 2024 · 3 comments
Open

Rethink / Reconsider / Revamp Babel presets #13149

paulincai opened this issue May 20, 2024 · 3 comments
Milestone

Comments

@paulincai
Copy link
Contributor

Screen generated with a Meteor 3-rc.1 project with meteor npm update:

Screenshot 2024-05-20 at 9 08 18 AM

@denihs denihs added this to the Release 3.0 milestone May 20, 2024
@denihs
Copy link
Contributor

denihs commented May 20, 2024

I tried to reproduce this but I couldn't. Did you do this in an app you migrated to version 3, or was it in an app created with Meteor 3 already?

Do you have the steps for reproduction?

@paulincai
Copy link
Contributor Author

Hi @denihs this is a project migrated to version 3 through each version since aroudn 2.5. Those notifications are generated by NPM (npm WARN) so I guess the Meteor version is less important.
babel-preset-meteor in the image has the latest version published on NPM which depends on deprecated packages.
https://www.npmjs.com/package/@babel/plugin-proposal-class-properties does have a deprecation notice in NPM like all the other packages in the screenshot.

https://www.npmjs.com/package/@babel/plugin-proposal-class-properties

I think what needs to be done is to implement the more official Babel way which depends on browserlist for the compilation of code. Meteor already offers a way to specify modern vs legacy browsers (the modern-browsers package) so I guess Babel should use those specs for compilation for those with particular needs and use some healthy industry defaults which are not Meteor specific. There are many issues with developers struggling with one version or another being or not being legacy, especially in Cordova.
Example of issues with managing browser versions:

@henriquealbert
Copy link
Member

I can confirm I had the same issue today. @denihs you can ask me how to reproduce it as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants