Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(58584): formatJSDocLink shouldn't introduce a trailing space when non link text. #58585

Merged
merged 1 commit into from
May 21, 2024
Merged

fix(58584): formatJSDocLink shouldn't introduce a trailing space when non link text. #58585

merged 1 commit into from
May 21, 2024

Conversation

JeanMeche
Copy link
Contributor

@JeanMeche JeanMeche commented May 20, 2024 •
edited

fixes #58584

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 20, 2024
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

@JeanMeche JeanMeche force-pushed the fix/58584 branch 2 times, most recently from 2170a23 to c56639a Compare May 20, 2024 14:20
@JeanMeche
Copy link
Contributor Author

If anyone come over here, I'd appreciate some help to fix the formating of tests/baselines/reference/linkTagEmit1.js, thank you in advance.

@JeanMeche JeanMeche force-pushed the fix/58584 branch 5 times, most recently from ecc5cf8 to e7150ac Compare May 20, 2024 16:06
@jakebailey
Copy link
Member

If anyone come over here, I'd appreciate some help to fix the formating of tests/baselines/reference/linkTagEmit1.js, thank you in advance.

Looks like a line ending problem. Did you use the baseline-accept task or did you manually modify the baseline?

@JeanMeche
Copy link
Contributor Author

I changed the file manually.

@jakebailey
Copy link
Member

Yeah, you shouldn't do that. Run the tests then run hereby baseline-accept. https://github.com/microsoft/TypeScript/blob/main/CONTRIBUTING.md#managing-the-baselines

@JeanMeche
Copy link
Contributor Author

@jakebailey Thanks, it looks better now !

jakebailey
jakebailey approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct to me. @sandersn may have a thought here.

@jakebailey jakebailey requested a review from sandersn May 20, 2024 19:55
@sandersn
Copy link
Member

I was briefly worried about the treatment of spaces with http:// but there are lots of tests of that already.

@sandersn sandersn merged commit 75342d8 into microsoft:main May 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@jakebailey jakebailey jakebailey approved these changes

Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getTextOfJSDocComment introduces a space in JSDoc comments
4 participants
@JeanMeche @typescript-bot @jakebailey @sandersn