Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing PageUp in search panel causes layout to shift #182308

Open
brawaru opened this issue May 12, 2023 · 3 comments · May be fixed by #213067
Open

Pressing PageUp in search panel causes layout to shift #182308

brawaru opened this issue May 12, 2023 · 3 comments · May be fixed by #213067
Assignees
@andreamah
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member search Search widget and operation issues
Milestone
On Deck

Comments

@brawaru
Copy link

brawaru commented May 12, 2023 •
edited

Type: Bug

  1. Go to search panel
  2. Type anything into search field
  3. Press Page Up (sometimes it's Page Down)

After that the layout shifts and hides the line indicating the current tab, which is annoying. You need to resize the window for layout to shift back, which fixes the problem.

Code_mIHgf0Rm7F.mp4

VS Code version: Code 1.78.2 (b3e4e68, 2023-05-10T14:39:26.248Z)
OS version: Windows_NT x64 10.0.19043
Modes:
Sandboxed: No

System Info
Item Value
CPUs Intel(R) Core(TM) i5-4440 CPU @ 3.10GHz (4 x 3093)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 11.95GB (3.80GB free)
Process Argv . --crash-reporter-id 00f2bb44-44e6-48df-99e8-c8d250a1afbb
Screen Reader no
VM 0%
Extensions (1)
Extension Author (truncated) Version
vscode-language-pack-de MS- 1.78.2023051009
A/B Experiments 
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes516:30244333
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vscccc:30610679
3biah626:30602489
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
a9j8j154:30646983
showlangstatbar:30737416
azdwalk:30721579
pythonms35:30701012
pythonfmttext:30731395
pythoncmvfstrcf:30731970
fixhidewlkth:30730051
hidesbindicator:30730055
@andreamah andreamah added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels May 15, 2023
@andreamah andreamah added this to the On Deck milestone May 15, 2023
@andreamah andreamah added the confirmed Issue has been confirmed by VS Code Team member label Dec 5, 2023
@franciscacarneiro
Copy link

Hello, I am a Computer Science student working on an open source project and I would like to contribute to this issue. Would it be possible for it to be attributed to me?
Thank you.

@andreamah
Copy link
Contributor

Hello, I am a Computer Science student working on an open source project and I would like to contribute to this issue. Would it be possible for it to be attributed to me? Thank you.

You can just start working on it :) I'm not too sure why this happens, so you can always try and investigate that first- from there, we can talk about a good fix!

franciscacarneiro added a commit to franciscacarneiro/vscode that referenced this issue Apr 5, 2024
@franciscacarneiro
fix microsoft#182308: Pressing PageUp in search panel no longer cause…
3047ca5 
…s layout to shift
franciscacarneiro added a commit to franciscacarneiro/vscode that referenced this issue Apr 5, 2024
@franciscacarneiro
Fix microsoft#182308: Pressing PageUp in the search panel no longer c…
40ccaf5 
…auses the layout to change.

Bug (previous behavior):
    1.Press Ctrl+Shift+F to open the search panel.
    2.Enter any text into the search input.
    3.Press PageUp/PageDown.
    4.The layout shifts to the right, hiding the line that indicates the current tab in the activity bar.

Solution:
When search results are displayed, pressing PageUp or PageDown now moves the cursor to the start or end of the search input, respectively. This is achieved by assigning specific functionality to these keys, overriding their default behavior of moving through the page.

Testing:
A smoke test was implemented to assess the fix. The test involves entering text into the search editor, pressing the PageUp and PageDown keys, and checking for any changes in the activity bar's layout.
franciscacarneiro added a commit to franciscacarneiro/vscode that referenced this issue Apr 15, 2024
@franciscacarneiro
Fix microsoft#182308: Pressing PageUp in the search panel no longer c…
b2ab0ed 
…auses the layout to change.

Bug (previous behavior):
    1.Press Ctrl+Shift+F to open the search panel.
    2.Enter any text into the search input.
    3.Press PageUp/PageDown.
    4.The layout shifts to the right, hiding the line that indicates the current tab in the activity bar.

Solution:
When search results are displayed, pressing PageUp or PageDown now moves the cursor to the start or end of the search input, respectively. This is achieved by assigning specific functionality to these keys, overriding their default behavior of moving through the page.

Testing:
A smoke test was implemented to assess the fix. The test involves entering text into the search editor, pressing the PageUp and PageDown keys, and checking for any changes in the activity bar's layout.
@franciscacarneiro
Copy link

Hello, I have created a solution that I believe fixes this bug! Is it okay to create a pull request?
Thank you.

@franciscacarneiro franciscacarneiro linked a pull request May 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreamah andreamah

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member search Search widget and operation issues
Projects
None yet
Milestone
On Deck
4 participants
@brawaru @andreamah @VSCodeTriageBot @franciscacarneiro