Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom brand cursor #1157

Closed
wants to merge 2 commits into from
Closed

Conversation

torranx
Copy link
Contributor

@torranx torranx commented May 20, 2024

Resolve #1154

  • Added brand cursor contributed by @Odizinne

In action:

Screen.Recording.2024-05-20.at.5.39.12.PM.mov

@danieland
Copy link
Contributor

I know very little about how color blindness works, and I'm not up to speed on WCAG/a11y standards for cursors, but my gut feeling says this should 100% be a menu option to turn on/off - curious what other people say though!

@torranx
Copy link
Contributor Author

torranx commented May 20, 2024

I know very little about how color blindness works, and I'm not up to speed on WCAG/a11y standards for cursors, but my gut feeling says this should 100% be a menu option to turn on/off - curious what other people say though!

Thanks for bringing this up. I agree, I think accessibility and user control should still be a priority over this so a menu to turn off/on is probably a must in this case. As per the color, since we're already using the colors used by the current logo, I think we're good.

There is a concern tho that the in-game settings we have now is quite more than what we'd like. But there is also another improvement in development for the in-game settings courtesy @Greenlamp2 so I guess until then, this PR is closed.

@karl-police
Copy link
Contributor

karl-police commented May 20, 2024

I know very little about how color blindness works, and I'm not up to speed on WCAG/a11y standards for cursors, but my gut feeling says this should 100% be a menu option to turn on/off - curious what other people say though!

different cursor different aim, different feeling, no

if I can't toggle this off, I set a breakpoint to where the game gets created, and put it under window.game to then destroy it

but since it's in the CSS, I destroy the CSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Contribution] I made a custom cursor
3 participants