Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding easy_responsive_images #72

Open
syzygy333 opened this issue May 13, 2024 · 3 comments
Open

Consider adding easy_responsive_images #72

syzygy333 opened this issue May 13, 2024 · 3 comments

Comments

@syzygy333
Copy link

Forgive me if this isn't the right place for this.

I can't think of a site that I haven't used easy_responsive_images on in years.

@syzygy333
Copy link
Author

The base config could provide some sensible defaults like
16:9
4:3
3:2
1:1

@phenaproxima
Copy link
Owner

This is absolutely the right place to discuss including this module in Starshot. :)

I certainly trust the author of the module (a fantastic media system co-maintainer), but I'd ideally like to see if anyone else is using this, or just collect a few more opinions about adding it. From reading the project page, I'm a bit concerned that this will generate a slew of extra image styles, which seems a bit pointless for Starshot since we can ship whatever config we want. But I'm certainly open to the possibility.

@roromedia
Copy link

If the module would have some sort of undo functionality it would be maybe handy, otherwise it is a pain to remove all generated styles by hand if someone mistyped something or needs to switch breakpoints.
In general I would also suggest to have sensible defaults preconfigured for responsive images out of the box - but again they should be removable also very easy - I am using TailwindCSS in all projects so I got the frameworks breakpoints from sm to 2xl for responsive images. If the defaults wouldn't be compatible I would need a quick way to change that. Maybe different recipes for different frontend frameworks as an addon to quickly swap existing defaults?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants