-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename apply-animated-style wrapper #20110
Comments
@Parveshdhull - We also have many instances of this being used in the style.cljs file which is bad because it means there is hooks hidden from the view. For this reason these guidelines need adjustment - https://github.com/status-im/status-mobile/blob/develop/doc/new-guidelines.md#animated-styles-in-the-style-file We should come up with some good examples of how we want to pass these styled values. 👍 |
cc @OmarBasem - |
@Parveshdhull why don't we remove |
hi @OmarBasem, probably @ulisesmac will have more info about that. But from, #18381
Also, from #18621 (review)
|
@OmarBasem
Yes, I just modified the (https://reactnative.dev/docs/0.73/style) It'd be great if we support them, we could get rid of the @ilmotta WDYT? do you think we can modify reagent to support this syntax? This is the place of the code that needs to be changed: The problem is that I think this is a dirty solution, so I'd like to explore if there's another way, maybe by using a custom compiler 🤔 |
I would also need to dig deeper to be sure @ulisesmac. My impression by skimming Reagent's source code is that the Reagent compiler is flexible, but maybe not as much as we need. For instance, props are converted in certain parts of |
Thanks @ulisesmac for the clarification. I am wondering, maybe we can edit our definition of |
Thank you for exploring the idea @ilmotta ! |
@OmarBasem (defn view []
(let [,,,]
[rn/view
[,,,]
[,,,]
(when something?
[reanimated/blur-view {,,,}])]
,,,)) Which is bad, because the hook is not declared at the beginning and also is wrapped in a condition. Seems very easy to make this mistake. |
That's right, makes sense. Thanks! |
Summary
Rename this wrapper to something like
use-...
so that dev know this wrapper is calling hookmore details: #20024 (comment)
#19945 (comment),
The text was updated successfully, but these errors were encountered: