Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wd-security 2.1.2.144 (new cask) #174386

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

unitof
Copy link
Contributor

@unitof unitof commented May 20, 2024

Reattempt of #173945: may have found a fix for the failing workflow, borrowed from anydesk.rb

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@unitof
Copy link
Contributor Author

unitof commented May 20, 2024

It passes! See #173945 for context.

Let me know if this is cheating! But seems to handle the plist that was tripping up the workflow, which is left behind by the uninstall script.

I may have overestimated by calling this "obscure"—it's needed by anyone with a number of Western Digital drives, and is a pain to find and install from WD, thus the desire for a Cask.

Also allows us to much better handle clean uninstallation, as evidenced by our reverse engineering struggles here.

@unitof unitof marked this pull request as ready for review May 20, 2024 22:01
@chenrui333 chenrui333 changed the title wd-security (new cask) wd-security 2.1.2.144 (new cask) May 20, 2024
Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we confirm that it doesn't require user-intervention on install? When I installed it locally it required an additional password outside of terminal before continuing.

It is definitely still hanging definitely for me.

Screenshot 2024-05-21 at 12 46 51 pm

@unitof
Copy link
Contributor Author

unitof commented May 21, 2024

It seems to prompt for that if Gatekeeper is enabled and it's been more that X minutes since the last time it was installs.

The prompt asks for biometrics with sudo: true, but prompts for full password when the formula doesn't call for sudo. Does that provide any clues how I might go about scripting around it?

As @bevanjkay noticed in the last PR, it seems the install .app is calling yet some other executable.

Understood if this is just a hard wall requiring interactivity—happy to bring this back to a personal tap and keep tinkering. Very happy with where it's gotten to.

@krehel
Copy link
Member

krehel commented May 30, 2024

@unitof are you using a machine with Apple Silicon? Also for @bevanjkay. I'm going to test this locally but thoughts below ⬇️

I worked on a strange issue with the mplab-xc16 cask that blocked an update for almost a year.

After a lot of tinkering on that cask, I found on Intel hardware behavior was normal, but installing on Apple Silicon produced an authentication UI similar to what is shown here, intermittently, which I assume was related to some auth caching. It also used an installer that was called directly with parameters, bypassing a .sh script.

Wondering if -

  1. It's the same installer family (not directly important)
  2. We don't use requires_rosetta and instead lock it down to Intel hardware with depends_on arch: :x86_64 (which solved the issue for mplab-xc16) that this issue goes away, but understanding that effectiveness is limited.

@unitof
Copy link
Contributor Author

unitof commented Jun 3, 2024

I am on Apple Silicon! Very interesting. Certainly worth a try. Do the test runners have any macOS security systems disabled or with non-default settings?

2 similar comments
@unitof
Copy link
Contributor Author

unitof commented Jun 3, 2024

I am on Apple Silicon! Very interesting. Certainly worth a try. Do the test runners have any macOS security systems disabled or with non-default settings?

@unitof
Copy link
Contributor Author

unitof commented Jun 3, 2024

I am on Apple Silicon! Very interesting. Certainly worth a try. Do the test runners have any macOS security systems disabled or with non-default settings?

@bevanjkay
Copy link
Member

Do the test runners have any macOS security systems disabled or with non-default settings?

No idea on this one. They are just the standard GitHub-provided runners.
I'm potentially okay including this depending on what we find, it passes CI.
The concern is that if it is run headlessly, or dispatched remotely, does it hang indefinitely until the process is stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants