Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paraview 5.12.0 #174393

Merged
merged 5 commits into from
May 22, 2024
Merged

paraview 5.12.0 #174393

merged 5 commits into from
May 22, 2024

Conversation

bobpaw
Copy link
Contributor

@bobpaw bobpaw commented May 21, 2024

Bump paraview to 5.12.
Bump Paraview bundled python version to 3.10 (in URLs). Update sha256 hashes.
Bump required MacOS version to 10.15 (indicated by URL).

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@bobpaw
Copy link
Contributor Author

bobpaw commented May 21, 2024

Audit is failing right now:

audit for paraview: failed
 - Version '5.12.0' differs from '5.12.20240229' retrieved by livecheck.
 - Version '5.12.0' differs from '5.12.20240229' retrieved by livecheck.
paraview
  * Version '5.12.0' differs from '5.12.20240229' retrieved by livecheck.
Error: 1 problem in 1 cask detected.

I'm not sure if this is something I didn't update or an intricacy of livecheck.

@bevanjkay
Copy link
Member

This is because the livecheck is matching this line "./nightly/ParaView-5.12.20240228-MPI-OSX11.0-Python3.10-arm64.dmg 2024-02-28 08:14 374793533"
Upstream must have changed the way the nightlies are listed. We will need to update the regex to skip these entries.

@bobpaw
Copy link
Contributor Author

bobpaw commented May 21, 2024

@bevanjkay, thanks! I was having trouble identifying the issue with brew livecheck --debug and I should have just scrolled down!

@miccal miccal requested a review from samford May 21, 2024 04:52
Casks/p/paraview.rb Outdated Show resolved Hide resolved
@samford samford added the livecheck Issues or PRs related to livecheck label May 21, 2024
@p-linnane
Copy link
Member

/rebase

bobpaw and others added 4 commits May 21, 2024 19:06
Bump paraview to 5.12.
Bump Paraview bundled python version to 3.10 (in URLs).
Update sha256 hashes.
Bump required MacOS version to 10.15 (indicated by URL).

Signed-off-by: Aiden Woodruff <aiden@aidenw.net>
Ignore nightly paraview releases in livecheck regex.

Signed-off-by: Aiden Woodruff <aiden@aidenw.net>
Remove reliance on Python version.
Remove reliance on macOS version.
Replace negative lookbehind with major version check.

Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
Remove first capturing group.

Signed-off-by: Aiden Woodruff <aiden@aidenw.net>
@miccal
Copy link
Member

miccal commented May 22, 2024

Thank you @bobpaw.

@miccal miccal merged commit 27e70dd into Homebrew:master May 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants