-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
robots 0.1.0 (new formula) #172094
base: master
Are you sure you want to change the base?
robots 0.1.0 (new formula) #172094
Conversation
f33950d
to
2a04ae0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have one suggestion below.
Also: this seems to download its own googletest
and abseil
at build-time (from master
/main
). We should use Homebrew googletest
and abseil
instead. See:
https://docs.brew.sh/Acceptable-Formulae#stuff-that-requires-vendored-versions-of-homebrew-formulae
https://docs.brew.sh/Acceptable-Formulae#we-dont-like-install-scripts-that-download-unversioned-things
2a04ae0
to
9128771
Compare
9128771
to
de9d494
Compare
I have opened the following issue to request to create a git tag. |
Thanks. There is also the issue of this downloading an unversioned Would you be able to submit a PR upstream that implements this? |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?