Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mactop 0.1.7 (new formula) #172135

Merged
merged 2 commits into from
May 21, 2024
Merged

mactop 0.1.7 (new formula) #172135

merged 2 commits into from
May 21, 2024

Conversation

metaspartan
Copy link
Contributor

@metaspartan metaspartan commented May 20, 2024 •
edited

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core macos-only Formula depends on macOS labels May 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@metaspartan
Copy link
Contributor Author

Bummer, exactly 30 days old lol, will wait to resubmit tomorrow unless a maintainer can just merge in?

chenrui333
chenrui333 reviewed May 20, 2024
View reviewed changes
Formula/m/mactop.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed May 20, 2024
View reviewed changes
Formula/m/mactop.rb Outdated Show resolved Hide resolved
chenrui333
chenrui333 reviewed May 20, 2024
View reviewed changes
Formula/m/mactop.rb Outdated Show resolved Hide resolved
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 20, 2024
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label May 20, 2024
@metaspartan
Copy link
Contributor Author

Added in your suggestions @chenrui333 thank you!

Looks like its passing all CI now 👍 🔥

@chenrui333
Copy link
Member

@metaspartan can you squash the commits and add the formula into autobump.txt, should be good after it.

@chenrui333 chenrui333 added the almost there PR is nearly ready to merge label May 21, 2024
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump and removed autosquash Automatically squash pull request commits according to Homebrew style. labels May 21, 2024
@metaspartan
Copy link
Contributor Author

@metaspartan can you squash the commits and add the formula into autobump.txt, should be good after it.

Squashed and added!

@metaspartan @chenrui333
mactop 0.1.6 (new formula)
d47cb1f 
Update Formula/m/mactop.rb

Update Formula/m/mactop.rb

Update Formula/m/mactop.rb

Update autobump.txt

Update mactop v0.1.7

Co-Authored-By: Rui Chen <rui@chenrui.dev>
@metaspartan metaspartan changed the title mactop 0.1.6 (new formula) mactop 0.1.7 (new formula) May 21, 2024
@chenrui333 chenrui333 removed almost there PR is nearly ready to merge automerge-skip `brew pr-automerge` will skip this pull request labels May 21, 2024
@chenrui333
Copy link
Member

@metaspartan, thanks for your first contribution to Homebrew-core!! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@chenrui333 chenrui333 removed the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 21, 2024
Merged via the queue into Homebrew:master with commit e64aeec May 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
autobump CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue macos-only Formula depends on macOS new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@metaspartan @chenrui333 @BrewTestBot