cmake: set ENABLE_DEBUG=ON by default for Debug builds
#13717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `CMAKE_BUILD_TYPE` is set to `Debug`, enable curl debug features by default. We do this to more closely match how autotools builds work, where `--enable-debug` enables both compiler debug feature and curl ones. You can override this by explicitly setting `ENABLE_DEBUG=OFF` and disable curl debug feature while leaving compiler debug enabled. Ref: curl#13592 (comment) Closes #xxxxx
|
Hm, looking at it, and how this may change existing configs ...this seems to make it more complex to figure out which configuration ends up enabling what. |
|
I thought about it some more and I think we should not do it, see my reply in #13592 (comment) |
|
Thanks @jay, agreed! Closing without merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
CMAKE_BUILD_TYPEis set toDebug, enable curl debug featuresby default. We do this to more closely match how autotools builds
work, where
--enable-debugenables both compiler debug feature andcurl ones.
You can override this by explicitly setting
ENABLE_DEBUG=OFFanddisable curl debug feature while leaving compiler debug enabled.
Ref: #13592 (comment)
Closes #13717
/cc @jay