Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Charting Editor Sustain Trails (2 bugs) #2565

Merged

Conversation

gamerbross
Copy link
Contributor

This pull request fixes two bugs:

Note Sustain Trails getting cut/inverted when is downscroll enabled

Before After
image image

Incorrect Sustain Trails origin note (based on ghost note)

Before After
Recording.2024-05-20.015437.mp4
Recording.2024-05-20.020011.mp4

Hope this gets added soon =D

@CharlesCatYT
Copy link

i got one of these problems before, tysm

@amyspark-ng
Copy link

the Incorrect Sustain Trails origin note has actually been bothering me for a while, this is cool :)

@EliteMasterEric
Copy link
Member

Approving because this does fix stuff, but currently Downscroll on chart editor doesn't fully work as intended (It's supposed to flip the note grid vertically and scroll upwards, I never properly implemented that which is why it's grayed out in the editor).

@gamerbross
Copy link
Contributor Author

Options downscroll and charting downscroll are separated things, the bug is related to options downscroll, a different check should be in ChartEditorHoldNoteSprite for charting downscroll. Should anyways revert it so at least the other fix gets merged?

@EliteMasterEric
Copy link
Member

Options downscroll and charting downscroll are separated things, the bug is related to options downscroll, a different check should be in ChartEditorHoldNoteSprite for charting downscroll. Should anyways revert it so at least the other fix gets merged?

Ah that explains it! We can leave flipY = true in place for now until I get around to making downscroll work.

@EliteMasterEric EliteMasterEric merged commit 0388f88 into FunkinCrew:develop May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants