-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds the new default settings view to onboarding #24562
base: develop
Are you sure you want to change the base?
feat: adds the new default settings view to onboarding #24562
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [a81133f]
Page Load Metrics (1002 ± 551 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [cf34cc7]
Page Load Metrics (803 ± 539 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [eb245b7]
Page Load Metrics (102 ± 119 ms)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #24562 +/- ##
===========================================
+ Coverage 65.64% 65.66% +0.02%
===========================================
Files 1367 1367
Lines 54257 54307 +50
Branches 14189 14218 +29
===========================================
+ Hits 35616 35659 +43
- Misses 18641 18648 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added a few quick nits, overall looks great!
ui/pages/onboarding-flow/creation-successful/creation-successful.js
Outdated
Show resolved
Hide resolved
Builds ready [317f8e9]
Page Load Metrics (154 ± 186 ms)
|
Builds ready [6e7b8e6]
Page Load Metrics (129 ± 151 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@yanrong-chen I've updated the UI, and addressed the other points as well 👍🏼 |
Builds ready [9c76427]
Page Load Metrics (123 ± 154 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
@zone-live just to double check: were you able to import |
|
Demo video: 338619599-8a4b48af-76ff-4186-86c7-c46df7b45677.mov |
Builds ready [7300c33]
Page Load Metrics (44 ± 3 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Introduces the new Default Settings view and Congratulations views depending on the fact if user imported a wallet or created a new one.
User imported a wallet:
User created a new wallet and backed up the seed phrase:
User created a new wallet and didn’t back up the seed phrase:
Inside look on the Default Settings:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist