Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: fix redesign metrics #24600

Merged
merged 2 commits into from
May 20, 2024
Merged

cherry-pick: fix redesign metrics #24600

merged 2 commits into from
May 20, 2024

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented May 20, 2024

Description

Fix metrics not showing ui_customization property

Open in GitHub Codespaces

Related issues

Fixes: #24578

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pnarayanaswamy pnarayanaswamy added the team-confirmations Push issues to confirmations team label May 20, 2024
@pnarayanaswamy pnarayanaswamy requested a review from a team as a code owner May 20, 2024 08:27
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.49%. Comparing base (f162192) to head (5bd1c44).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           Version-v11.17.0   #24600      +/-   ##
====================================================
- Coverage             67.49%   67.49%   -0.00%     
====================================================
  Files                  1288     1288              
  Lines                 50153    50152       -1     
  Branches              13018    13018              
====================================================
- Hits                  33848    33847       -1     
  Misses                16305    16305              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [5bd1c44]
Page Load Metrics (1756 ± 603 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641921093014
domContentLoaded10341573
load60330617561255603
domInteractive10341573
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 420 Bytes (0.01%)
  • ui: 35 Bytes (0.00%)
  • common: 89 Bytes (0.00%)

@digiwand digiwand merged commit bd5f6ca into Version-v11.17.0 May 20, 2024
69 checks passed
@digiwand digiwand deleted the cp-metrics-fix branch May 20, 2024 17:51
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-11.17.0 on PR, as PR was cherry-picked in branch 11.17.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.0.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants