-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/update controller is_stuck() #1891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think CmdOutputObservation and maybe the KillAction should ignore the command_id for the purpose of this check. I made an override of eq for the first, but I reverted from this PR to give it some thought. Any feedback is appreciated!
I agree on this point -- we are only interested in comparing the "content" of the observation, but not something else. Happy to hear what other people think
I think it would be interesting to run this PR against FYI log is here: |
@@ -0,0 +1,224 @@ | |||
from unittest.mock import Mock, patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to say "it'd be great to get some unit tests in here" and then I scrolled down a bit 😄
Thanks for this!
Fix the stuck check in the controller:
Please note:
command_id
for the purpose of this check. I made an override of eq for the first, but I reverted from this PR to give it some thought. Any feedback is appreciated!