fix(elvish): before-chdir should assign to oldpwd upvalue #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elvish uses lexical scoping for closure capture, as such all `oldpwd` references within the script refers to the `oldpwd` defined at the top. However, before-chdir hook is trying to assign to `oldpwd` within the editor scope, which is not used by this script. This manifested as a bug in which: ``` ~ > mkdir -p /tmp/another ~ > z /tmp /tmp > z another /tmp/another > z - ~ > # The previous dir should be /tmp not ~! ``` Because the hook was updating a variable that was not used. Fix the hook so that before-chdir assign to the proper upvalue.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elvish uses lexical scoping for closure capture, as such all
oldpwdreferences within the script refers to theoldpwddefined at the top. However, before-chdir hook is trying to assign tooldpwdwithin the editor scope, which is not used by this script.This manifested as a bug in which:
Because the hook was updating a variable that was not used.
This PR fixes the hook so that before-chdir assign to the proper upvalue.