-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow Adding User Over Limit From Console In Team Membership #8122
fix: Allow Adding User Over Limit From Console In Team Membership #8122
Conversation
5d60a77
to
6ff3fc5
Compare
Co-authored-by: Steven Nguyen <1477010+stnguyen90@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please also add test cases. The best place is probably here:
appwrite/tests/e2e/Services/Projects/ProjectsConsoleClientTest.php
Lines 1243 to 1254 in 0a3914d
$response = $this->client->call(Client::METHOD_POST, '/account', array_merge([ | |
'origin' => 'http://localhost', | |
'content-type' => 'application/json', | |
'x-appwrite-project' => $id, | |
]), [ | |
'userId' => ID::unique(), | |
'email' => $email, | |
'password' => $password, | |
'name' => $name, | |
]); | |
$this->assertEquals($response['headers']['status-code'], 501); |
2 API calls should be called using the Console account (include the headers like here):
- POST /users
- POST /teams/id/memberships (you'll need to create the team first too)
…r-over-limit-from-console-or-apikey
What does this PR do?
It allows Adding user over limit from console in team membership.
Fixes #5516
Test Plan
Manual
Screencast.from.2024-05-15.15-14-29.mp4
Related PRs and Issues
Checklist