-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose wether a module has TLA or not as .extra.async #16480
base: main
Are you sure you want to change the base?
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56855 |
Would it be better to just use |
64070c7
to
0b4799c
Compare
Renamed to |
5e72f56
to
d3dd293
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test case for module expressions if there aren't such test? The current implementation should already work.
The parser already has this info, and having to detect it by yourself is error prone (due to computed keys and decorators).
We can also use this to warn in the CJS transform when there is top-level await (in a follow-up).