Setup dagger engines with buildkit gc disabled #7376
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up from an internal discussion where @samalba has been investigating the performance of our CI and found that disabling bulidkit's GC has the potential of improving stability of the most heavy jobs. We want to test this in production for a few days and have side by side data to compare the performance and stability of the jobs. I've been running a few isolated tests here: https://github.com/dagger/dagger/actions/runs/9084221778, but we need more data in order to drive a conclusion regarding the GC.
In this PR we are adding two jobs for the engine-and-cli workflow:
This jobs will run in parallel and in a synchronous manner to baseline jobs. To implement it there were two minor changes introduced to
_dagger_call
:runs-on
for testdev which we couldn't so far.