Add Values.engine.labels value to Helm Chart. #7412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerhard
approved these changes
May 21, 2024
Signed-off-by: yibble <nreynolds@rockwellautomation.com>
gerhard
force-pushed
the
helm_chart_labels
branch
2 times, most recently
from
ce9a943
to
e259f73
Compare
|
Thank you for a great first contribution @yibble! I removed the |
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 24, 2024
Signed-off-by: yibble <nreynolds@rockwellautomation.com>
vikram-dagger
pushed a commit
to vikram-dagger/dagger
that referenced
this pull request
May 24, 2024
Signed-off-by: yibble <nreynolds@rockwellautomation.com> Signed-off-by: Vikram Vaswani <vikram@dagger.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required in cases where labels are required to provide access, ETC. I.E.:
I need this change because I'd like to execute Terraform code in Dagger Runners under an Azure MSI context using aadPodIdentity in an AKS cluster. To provide the necessary access, the dagger-engine DaemonSet requires an
aadpodidentitylabel for aadPodIdentity to attach an Azure MSI context to it.