-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(guild): Remove deprecated get guild overload #10052
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pointless to block such a trivially backwards compatible change until the next major. We should just make overloads and deprecate the current one, IMO.
I guess we can, but do we want to put as much effort in it, especially that is is not that important |
yes, I'd advise you just do it, it takes like 2 minutes. |
so just add an overload for the past behavior and check if the reason property exists in the object |
yes. |
Opened #10143: a non-breaking pull request. This one may remain for the next major version. |
7927e93
to
32ac62f
Compare
32ac62f
to
92f7b3d
Compare
Please describe the changes this PR makes and why it should be merged:
Removes the deprecated overload from getting a guild.
Status and versioning classification: