Implement thread-safety for LazyShadowTreeRevisionConsistencyManager #44619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57506540 |
…acebook#44619) Summary: Some methods in `LazyShadowTreeRevisionConsistencyManager` can be called in parallel when using synchronous state updates (which is also behind a flag). This implements thread-safety to cover that case so we don't have issues when testing that variant in production. Changelog: [internal] Differential Revision: D57506540
rubennorte
force-pushed
the
export-D57506540
branch
from
e092d6a
to
356c06b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57506540 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 20, 2024
…acebook#44619) Summary: Some methods in `LazyShadowTreeRevisionConsistencyManager` can be called in parallel when using synchronous state updates (which is also behind a flag). This implements thread-safety to cover that case so we don't have issues when testing that variant in production. Changelog: [internal] Differential Revision: D57506540
Base commit: de1967d |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
May 20, 2024
…cyManager (facebook#44619) Summary: Some methods in `LazyShadowTreeRevisionConsistencyManager` can be called in parallel when using synchronous state updates (which is also behind a flag). This implements thread-safety to cover that case so we don't have issues when testing that variant in production. Changelog: [internal] Reviewed By: NickGerleman Differential Revision: D57506540
|
This pull request has been merged in 98bf5ef. |
|
This pull request was successfully merged by @rubennorte in 98bf5ef. When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some methods in
LazyShadowTreeRevisionConsistencyManagercan be called in parallel when using synchronous state updates (which is also behind a flag). This implements thread-safety to cover that case so we don't have issues when testing that variant in production.Changelog: [internal]
Differential Revision: D57506540