-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship][deliver][pilot] add support for app clips default experience metadata and review information #22041
Open
sa-ma
wants to merge
24
commits into
fastlane:master
Choose a base branch
from
sa-ma:pilot-app-clips
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix error in pr comment: fastlane#20300 (comment)
sa-ma
changed the title
[spaceship][deliver][pilot] add support for app clips default experience metadata and review information
[WIP] [spaceship][deliver][pilot] add support for app clips default experience metadata and review information
May 20, 2024
sa-ma
changed the title
[WIP] [spaceship][deliver][pilot] add support for app clips default experience metadata and review information
[spaceship][deliver][pilot] add support for app clips default experience metadata and review information
May 27, 2024
@rogerluan and @AliSoftware please can you help review. There is no option to request for a reviewer on the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
This PR improves #21180 which seems to have been abandoned. My team and I have been using the changes from #21180 for a while now. I have synced the branches and fixed failing tests.
Resolves #17639
Description
Deliver
The following app clip default experience functionality has been added to deliver:
See #21180 for examples
Testing Steps
Basic Testing Setup
What to Test
Deliver
Before specifying any deliver options:
After specifying the app clip default experience deliver options:
Pilot