Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for restorable_value.0.dart API example. #148676

Merged
merged 3 commits into from
May 23, 2024
Merged

Add tests for restorable_value.0.dart API example. #148676

merged 3 commits into from
May 23, 2024
+69 −13

Conversation

ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented May 20, 2024 •
edited

This PR contributes to #130459

Description

  • Updates examples/api/lib/widgets/restoration_properties/restorable_value.0.dart to meet the latest API examples structure
  • Adds tests for examples/api/lib/widgets/restoration_properties/restorable_value.0.dart

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 20, 2024
TahaTesser
TahaTesser approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/api/test/widgets/restoration_properties/restorable_value.0_test.dart Outdated
import 'package:flutter_test/flutter_test.dart';

void main() {
testWidgets('increments answer on OutlinedButton tap', (WidgetTester tester) async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize the initial word

examples/api/test/widgets/restoration_properties/restorable_value.0_test.dart Outdated
expect(find.text('43'), findsOneWidget);
});

testWidgets('restores answer value after restart', (WidgetTester tester) async {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize the initial word

@ksokolovskyi ksokolovskyi force-pushed the add-restorable-value-example-tests branch from a302abc to 565533b Compare May 22, 2024 07:29
@ksokolovskyi ksokolovskyi mentioned this pull request May 22, 2024
Merged
9 tasks
bleroux
bleroux approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice!

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2024
@auto-submit auto-submit bot merged commit 3beeed4 into flutter:master May 23, 2024
139 checks passed
@ksokolovskyi
Copy link
Contributor Author

@TahaTesser @bleroux thanks for the review and merge!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
3beeed492 Add tests for restorable_value.0.dart API example. (flutter…
2eb74df 
…/flutter#148676)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
3beeed492 Add tests for restorable_value.0.dart API example. (flutter…
e1015b8 
…/flutter#148676)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 23, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
3beeed492 Add tests for restorable_value.0.dart API example. (flutter…
0cf66eb 
…/flutter#148676)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 23, 2024
@engine-flutter-autoroll
Roll Flutter from 73bf206f35e7 to 8d955cdd644e (24 revisions) (#6786)
1008d9e 
flutter/flutter@73bf206...8d955cd

2024-05-23 nate.w5687@gmail.com Update `FocusManager` platform check to include iOS (flutter/flutter#148612)
2024-05-23 matej.knopp@gmail.com [iOS] fix hot restart with native assets (flutter/flutter#148752)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8b82454e302 to 964f087f288c (8 revisions) (flutter/flutter#148943)
2024-05-23 104349824+huycozy@users.noreply.github.com Fix DecoratedSliver sample code to reflect the description (flutter/flutter#148621)
2024-05-23 82763757+NobodyForNothing@users.noreply.github.com Test raw autocomplete api examples (flutter/flutter#148234)
2024-05-23 32538273+ValentinVignal@users.noreply.github.com Add test for scaffold.0.dart and scaffold.2.dart (flutter/flutter#148166)
2024-05-23 sokolovskyi.konstantin@gmail.com Add tests for restorable_value.0.dart API example. (flutter/flutter#148676)
2024-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8b094fbb94d8 to b8b82454e302 (6 revisions) (flutter/flutter#148919)
2024-05-22 31859944+LongCatIsLooong@users.noreply.github.com Allow `RenderObject.getTransformTo` to take an arbitrary RenderObject in the same tree (flutter/flutter#148897)
2024-05-22 kevinjchisholm@google.com 3.22.1 changelog updates (flutter/flutter#148895)
2024-05-22 helinx@google.com Add frame number and widget location map service extension (flutter/flutter#148702)
2024-05-22 31859944+LongCatIsLooong@users.noreply.github.com Remove an assert with false positives (flutter/flutter#148795)
2024-05-22 rmolivares@renzo-olivares.dev Revert "Fix the second TextFormField to trigger onTapOutside" (flutter/flutter#148909)
2024-05-22 katelovett@google.com [wiki migration] Remaining pages under docs/about/ (flutter/flutter#148782)
2024-05-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from b6971cdf14f8 to 8b094fbb94d8 (3 revisions) (flutter/flutter#148883)
2024-05-22 42757204+wyqlxf@users.noreply.github.com Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148206)
2024-05-22 34871572+gmackall@users.noreply.github.com Try removing robolectric from `integration_test` tests (flutter/flutter#148803)
2024-05-22 victoreronmosele@gmail.com Prevent test folder deletion on running `flutter create --empty` on an existing app project (flutter/flutter#147160)
2024-05-22 katelovett@google.com [wiki migration] Tool team pages (flutter/flutter#148779)
2024-05-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from c89defa55801 to b6971cdf14f8 (6 revisions) (flutter/flutter#148819)
2024-05-22 dacoharkes@google.com [native_assets] Add support for link hooks (flutter/flutter#148474)
2024-05-22 engine-flutter-autoroll@skia.org Roll Packages from ba19b24 to 6525441 (12 revisions) (flutter/flutter#148864)
2024-05-22 36861262+QuncCccccc@users.noreply.github.com Update tokens to 4.0.0 (flutter/flutter#148789)
2024-05-22 zanderso@users.noreply.github.com Move Linux web_long_running_tests_2_5 to bringup (flutter/flutter#148854)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Piinks Piinks mentioned this pull request May 31, 2024
Open
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@ksokolovskyi @victorsanni
Add tests for restorable_value.0.dart API example. (flutter#148676)
2e0f9e0 
This PR contributes to flutter#130459

### Description
- Updates `examples/api/lib/widgets/restoration_properties/restorable_value.0.dart` to meet the latest API examples structure
- Adds tests for `examples/api/lib/widgets/restoration_properties/restorable_value.0.dart`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroux bleroux bleroux approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ksokolovskyi @bleroux @TahaTesser