Tesla wall connector add sensors #117769
Merged
Tesla wall connector add sensors #117769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
has-tests
integration: tesla_wall_connector
new-feature
small-pr
|
Hey there @einarhauks, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
edenhaus
requested changes
May 20, 2024
|
Tests are set up more or less correctly, just needs some scaffolding to enable disabled sensors in the test flow. Will attempt to fix this in a bit. |
…t#117644) * initial commit * Undo prompt chenges * Move format_tool out of the class * Only catch HomeAssistantError and vol.Invalid * Add config flow option * Fix type * Add translation * Allow changing API access from options flow * Allow model picking * Remove allowing HASS Access in main flow * Move model to the top in options flow * Make prompt conditional based on API access * convert only once to dict * Reduce debug logging * Update title * re-order models * Address comments * Move things * Update labels * Add tool call tests * coverage * Use LLM APIs * Fixes * Address comments * Reinstate the title to not break entity name --------- Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: J. Nick Koston <nick@koston.org>
|
Handling disabled sensors in the tests seems to require quite a bit of refactoring, so for now I just enabled the sensors by default. |
edenhaus
requested changes
May 20, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
This reverts commit c9ef8de.
edenhaus
approved these changes
May 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds sensor definitions for the PCBA and MCU temperature sensors. The sensor values are already retrieved and made available by the underlying tesla_wall_connector library.
As not all users may be interested in the added sensor values, as evidenced by their lack of inclusion up to now, the sensors will be disabled by default.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: