-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fallback_ips: Gather facts from reachable hosts only #11006
base: master
Are you sure you want to change the base?
Conversation
Hi @Rickkwa. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Rickkwa The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Do you need any more info from me to move this forward? I'm hoping this can get into the 2.25 release, whenever that is. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When working with a large fleet of nodes, there is inevitably going to be some unreachable nodes. The linked issue describes that when
kubespray-defaults
runs and there exists an unreachable node, then it causes the play to unexpectedly exit early.This is a fix to
fallback_ips.yml
to let it finish the rest of the role when unreachable node(s) exist.Which issue(s) this PR fixes:
Fixes #10993
Special notes for your reviewer:
Local setup (inventory and test playbook):
details
InventoryPlaybook
Showing the original output before applying my PR:
details
After my PR:
details
Also to note, I originally tried making this change to add
ignore_errors: true
:details
But as you can see, while it got past the early exit, it looks like it doesn't save the discovered facts. And so the output is all wrong. That's why I decided to first filter out the unreachable hosts in a separate task before running
setup
.Does this PR introduce a user-facing change?:
None