Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFn: handle secretsmanager policy BlockPublicPolicy #10850

Merged

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented May 20, 2024

Motivation

When deploying an AWS::SecretsManager::ResourcePolicy resource with CloudFormation, if BlockPublicPolicy is not specified, it should default to True however in LocalStack it is represented as None which is not a valid type for this property.

Changes

  • Default the property to True if not specified
  • Update existing test that creates a ResourcePolicy to either specify the value, or use AWS::NoValue to not provide a value

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label May 20, 2024
@simonrw simonrw self-assigned this May 20, 2024
@simonrw simonrw marked this pull request as ready for review May 20, 2024 14:06
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 40m 41s ⏱️ + 1m 16s
2 980 tests +1  2 675 ✅ +1  305 💤 ±0  0 ❌ ±0 
2 982 runs  +1  2 675 ✅ +1  307 💤 ±0  0 ❌ ±0 

Results for commit c1e1461. ± Comparison against base commit e3db788.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
tests.aws.services.cloudformation.resources.test_secretsmanager ‑ test_cfn_secret_policy
tests.aws.services.cloudformation.resources.test_secretsmanager ‑ test_cfn_secret_policy[default]
tests.aws.services.cloudformation.resources.test_secretsmanager ‑ test_cfn_secret_policy[true]

@simonrw simonrw merged commit a462e47 into master May 20, 2024
33 checks passed
@simonrw simonrw deleted the cfn/secretsmanager/correct-default-block-public-policy branch May 20, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants