Removes prettier from ESLint plugin #12861
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the test of the eslint plugin is breaking. Was it working before @StorytellerCZ? It works locally at least but I didn't check how it's configured to run here. |
|
The tests here look strange. They are working elsewhere as far as I can remember. |
|
The error is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ESLint configuration inside this plugin conflicts with the Meteor main repo configuration.
ESLint plugins shouldn't worry about code styles nowadays. This is something for Prettier.
So, I just removed it from the plugin.
Without these changes, I'm not even able to run the tests of this plugin locally.
BTW, let's add this test runner to the CI here in this repo. I don't think it's running.