STOR-1892: Add option to disable all monitors #28815
Conversation
jsafrane
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@jsafrane: This pull request references STOR-1892 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
`openshift-tests run --disable-monitor all` disables all monitors, so the output and artifacts are not polluted by monitors, but contain the ginkgo test results only. This is useful when running the tests by a human and not in CI.
When no in-cluster monitoring daemon sets run, StartInClusterMonitors() is not called and `namespace` is empty. Nothing produces /tmp/artifacts/junit/AdditionalEvents__in_cluster_disruption.json on the nodes and thus do not collect it. This removes following error: found errors fetching in-cluster data: [failed to list files in disruption event folder on node ip-10-0-19-0.ec2.internal: the server could not find the requested resource ]
|
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: d9a2c99
|
openshift-tests run --disable-monitor alldisables all monitors, so the output and artifacts are not polluted by monitors, and contain the ginkgo test results only.This is useful when running the tests by a human and not in CI - the monitors are very talkative on stdout. We use openshift-tests as a certification suite for CSI drivers and 3rd party CSI driver vendors are not interested in the OCP health, they're interested in the CSI driver test results.
In addition, when all monitors are disabled, do not collect
AdditionalEvents__in_cluster_disruption.jsonfrom nodes - there are no monitoring DaemonSets running.