Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Zero to hero #1131

Merged
merged 8 commits into from
May 28, 2024
Merged

Conversation

XGSleepWalker
Copy link
Collaborator

@XGSleepWalker XGSleepWalker commented May 19, 2024

Context for this PR:

  • Implements Zero to Hero for Palafin
  • Fixes permanent form for all pokemon (forms should be reset on biome change or trainer battle, essentially on forced recall)
  • Fixes PreSwitchOut attributes being erroneously triggered on the forced recall.
  • Changes PostBattleInit attributes to only being triggered on the forced recall.
  • Forces the following abilities to be reverted on forced recall: Zen Mode, Shields Down, Schooling, Disguise, Battle Bond, Power Construct, Zero to Hero
  • Marks Ogerpon's Embody Aspect as partial. (It will be reworked later on when we go back to rework on the Terastallization mechanics)
  • Adds a new bypass for abilities to be forcefully triggered. (Form abilities shouldn't be triggered on death, but they should be able to be reverted regardless on forced recall).

src/overrides.ts Outdated Show resolved Hide resolved
@bennybroseph bennybroseph added the Ability Affects an ability label May 19, 2024
Copy link
Collaborator

@bennybroseph bennybroseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get a video of how this was tested?

src/data/ability.ts Outdated Show resolved Hide resolved
src/overrides.ts Outdated Show resolved Hide resolved
@LaukkaE
Copy link
Collaborator

LaukkaE commented May 19, 2024

  • [ * ] Palafin switches to the correct form, and also back correctly.

  • [ * ] Works with Self switching moves, as well as opponents force switching moves.

  • [ * ] If form is fusioned with another pokemon, stays in the form indefinitely while fusioned.

  • [ * ] No console Errors found while testing.

  • [ * ] If another pokemon that has another form should somehow acquire Zero to Hero, the ability will announce itself, but not change the form.

  • [ * ] Not affected by Trace, Gastro Acid, etc.

  • [ * ] Fainting will not cause the form to change back.

  • [ * ] Changes the form even on the "free" switch. (Should it? Idk.)

Feature wise, seems to work correctly.

@XGSleepWalker XGSleepWalker marked this pull request as draft May 19, 2024 23:30
@XGSleepWalker XGSleepWalker self-assigned this May 21, 2024
@XGSleepWalker XGSleepWalker marked this pull request as ready for review May 21, 2024 23:30
@bennybroseph bennybroseph merged commit 89f5896 into pagefaultgames:main May 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants