-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Achievements localization, organized some locales files and ptBR translations #1150
Achievements localization, organized some locales files and ptBR translations #1150
Conversation
I'll be adding the achv.ts file for the other languages (english by default) |
Ready for review. Help wanted. |
…e issues with german localization at other parts
Fixed Achivment Localization, Added german localization and fixes som…
Ready for commit. |
I subbitted a French translation to your branch |
Update French achv.ts
Made a tiny typo correction to French achiv file |
French typo correction achv.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the 2 lines
import {Achv, getAchievementDescription} from "../system/achv";
and
this.descriptionText.setText(getAchievementDescription((achv as Achv).localizationKey));
for the file src/ui/achv-bar.ts
are necessary, the rest is a merge error, and produces some nasty interface errors
How? Like i did a merge request to his branch that did exactly what you said. (take main and only change the lines). Didnt he merge my pr to his branch in (yet?) |
He didn't merge your PR |
Did i do.it correctly? (And yes the Voucher Thing is necessary at the description) |
Yes indeed, there is also the condition for the voucher description, I skipped it without paying attention 😅 |
Vouchers now will show the correct descrption again
Missings import at import { Achv } from "../system/achv"; to import { Achv, getAchievementDescription } from "../system/achv"; |
fixed |
The PR still has build warnings, it will be merged once these are cleared.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the build warnings, we'll merge it then.
@XGSleepWalker organized imports and removed duplicates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
korean locales suggested
Localized whole achievements screen, added some ptBR translations and organized imports, classes and languages in alphabetical order. (and added some commas in ptBR locales)
Achievements (english)
Locked Achievement (ptBR)
Achievements (ptBR)
Locked Achievement (ptBR)