Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(translations): ai translation script should use formal language #6433

Merged
merged 1 commit into from
May 21, 2024

Conversation

paulpopus
Copy link
Contributor

Added additional prompt to make sure the translation we receive is using formal language where it makes sense.

In the context of latin languages for example:

  • Spanish: "tu" should be using "vos"
  • French: "tu" should be using "votre"

These differences can affect verb conjugations and in these languages it comes across as less professional if informal language is used.

Type of change

  • Chore (non-breaking change which does not add functionality)

@paulpopus paulpopus requested a review from AlessioGr May 20, 2024 15:18
@paulpopus paulpopus changed the title chore: AI translation script should use formal language chore(translations): AI translation script should use formal language May 20, 2024
@paulpopus paulpopus changed the title chore(translations): AI translation script should use formal language chore(translations): ai translation script should use formal language May 20, 2024
Copy link
Member

@denolfe denolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only affects future translation keys, correct?

@denolfe denolfe merged commit f51af92 into beta May 21, 2024
35 of 37 checks passed
@denolfe denolfe deleted the chore/translation-script-should-use-formal-language branch May 21, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants