Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(backport): include latest changes of v4 in v3 #4027

Merged
merged 19 commits into from
May 21, 2024
Merged

chore(backport): include latest changes of v4 in v3 #4027

merged 19 commits into from
May 21, 2024

Conversation

sergargar
Copy link
Member

Description

Include latest changes of v4 in v3.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

uridealo and others added 11 commits May 20, 2024 11:27
@uridealo @jfagoagas @sergargar
fix(rds): add ReadReplicaSourceDBInstanceIdentifier to db_instance (#…
0465888 
…3912)

Co-authored-by: Pepe Fagoaga <pepe@prowler.com>
@sergargar
feat(ec2): add EC2 Security group check to verify if at least one por…
9c24bf9 
…t is opened (#3962)
@jfagoagas @sergargar
chore(regions_update): Changes in regions for AWS services. (#3965)
bb12287 
Co-authored-by: sergargar <38561120+sergargar@users.noreply.github.com>
@madereddy @sergargar
chore(rds): support more AWS RDS DB Instance engines in encryption ch…
66933ff 
…eck (#3968)
@jfagoagas @sergargar
chore(regions_update): Changes in regions for AWS services. (#3971)
7bc1437 
Co-authored-by: sergargar <38561120+sergargar@users.noreply.github.com>
@pedrooot @sergargar
chore(deps): remove mrestazure deprecated (#3974)
6fe60b4
@jfagoagas @sergargar
chore(regions_update): Changes in regions for AWS services. (#4009)
e3f6a56 
Co-authored-by: sergargar <38561120+sergargar@users.noreply.github.com>
@pedrooot @sergargar
fix(elasticache): make previous comprobations for subnet (#4014)
90194d0
@jfagoagas @sergargar
chore(regions_update): Changes in regions for AWS services. (#4017)
dcdb458 
Co-authored-by: sergargar <38561120+sergargar@users.noreply.github.com>
@sergargar
chore(compliance): change security group any port check (#4019)
b85df0a
@jfagoagas @sergargar
chore(regions_update): Changes in regions for AWS services. (#4023)
b23749a
@sergargar sergargar requested review from a team as code owners May 20, 2024 16:12
@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider labels May 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@sergargar
Copy link
Member Author

Please @jfagoagas add PRs #4024 and #3969.

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

Attention: Patch coverage is 86.56716% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 86.74%. Comparing base (a3cfca5) to head (4f13299).

Files Patch % Lines
prowler/providers/aws/aws_provider.py 46.15% 7 Missing ⚠️
.../providers/aws/services/ec2/lib/security_groups.py 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##               v3    #4027   +/-   ##
=======================================
  Coverage   86.73%   86.74%           
=======================================
  Files         712      713    +1     
  Lines       22193    22242   +49     
=======================================
+ Hits        19249    19293   +44     
- Misses       2944     2949    +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@jfagoagas
Copy link
Member

Please @jfagoagas add PRs #4024 and #3969.

Done!

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

jfagoagas
jfagoagas previously approved these changes May 21, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@github-actions GitHub Actions
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@sergargar sergargar requested a review from jfagoagas May 21, 2024 15:03
@sergargar sergargar merged commit fd46c70 into v3 May 21, 2024
11 of 12 checks passed
@sergargar sergargar deleted the backport-3.16.5 branch May 21, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfagoagas jfagoagas jfagoagas approved these changes

Assignees
No one assigned
Labels
documentation provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sergargar @jfagoagas @uridealo @madereddy @pedrooot