Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UFMT format on test/test_nn.py #126663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hippocookie
Copy link
Contributor

@hippocookie hippocookie commented May 20, 2024

Fixes some files in #123062

Run lintrunner on files:
test/test_nn.py

$ lintrunner -a --take UFMT --all-files
ok No lint issues.
Successfully applied all patches.

cc @albanD

Copy link

pytorch-bot bot commented May 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126663

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 019d533 with merge base f6e303f (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 20, 2024
@hippocookie hippocookie marked this pull request as ready for review May 20, 2024 07:00
@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 20, 2024
@drisspg drisspg requested a review from albanD May 20, 2024 20:53
@mikaylagawarecki
Copy link
Contributor

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased enable_ufmt2 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout enable_ufmt2 && git pull --rebase)

Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hippocookie Thanks for taking this on, it seems like there might still be a couple more ufmt failures https://hud.pytorch.org/pr/pytorch/pytorch/126663#25386453576, could you fix these please?

@hippocookie
Copy link
Contributor Author

Due to inconsistent of my black version, there's some wrong format not found on my machine, I think this time it might be work, thanks for you help! :D @mikaylagawarecki

@mikaylagawarecki
Copy link
Contributor

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/126663/head returned non-zero exit code 1

Rebasing (1/1)
Auto-merging .lintrunner.toml
Auto-merging test/test_nn.py
CONFLICT (content): Merge conflict in test/test_nn.py
error: could not apply 4b1d09e0c27... UFMT format on test/test_nn.py
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Could not apply 4b1d09e0c27... UFMT format on test/test_nn.py

Raised by https://github.com/pytorch/pytorch/actions/runs/9306177352

Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like lint is passing now, thank you!

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 31, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request merging open source skip-pr-sanity-checks topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants