-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error fix in accordian #2666 issue fix #1 #2684
base: master
Are you sure you want to change the base?
Conversation
qburst-harikrishnanp
commented
Jan 23, 2023
- Bug fix
- New feature
- Chore
- Breaking change
- There is an open issue which this change addresses
- I have read the CONTRIBUTING document.
- My commits follow the Git Commit Guidelines
- My code follows the code style of this project.
- My change requires a change to the documentation.
- I have updated the documentation accordingly.
- My change requires a change to Typescript typings.
- I have updated the typings accordingly.
- I have added tests to cover my changes.
- All new and existing tests passed.
Error fix in accordian reactstrap#2666 issue fix
Issue fix for reactstrap#2681 - AccordionBody className prop sets class of parent div, not accordion-body div
@illiteratewriter @aaronmars Please approve |
@illiteratewriter @aaronmars Please approve |
The @qburst-harikrishnanp Can you let us know what exactly you're trying to achieve with this particular PR? |
@illiteratewriter This PR will resolve both the above mentioned issues. |
The current PR has the issue that it is changing the structure of how accordion works in bootstrap. In Bootstrap docs the accordion works as following: <div class="accordion-collapse collapse">
<div class="accordion-body">
This is the second item's accordion body.
</div>
</div> As you can see, <div class="collapse">
<div class="accordion-body accordion-collapse ">
This is the second item's accordion body.
</div>
</div> This also breaks the library for those who have applied classes previously, because there is a change in behavior. The solution to this would be to add an additional prop, something like Modal.js implements something similar to this. You can look at it for inspiration. Let me know if you have any questions. |
Thanks for the input. |
reverting the fix done for reactstrap#2681