-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of Python 3.12 #2098
base: staging
Are you sure you want to change the base?
Support of Python 3.12 #2098
Conversation
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
let's try, this can be as simple as changing a few lines of code, or we might need to fix many dependencies.
Error in Cornac dependency:
|
Other error, it seems it's coming from dependencies:
source: https://github.com/recommenders-team/recommenders/actions/runs/9090676506/job/24984293755 |
As the problem is with setuptools, perhaps upgrading it or forcing a more recent version should suffice. I think cornac fails just because it is the first thing to be installed with that method. According to that issue, changing the dependency to
|
Now the requirements are fine, but it errors after installing build dependencies and I can't see why
Source: https://github.com/recommenders-team/recommenders/actions/runs/9090676506/job/24984293755 |
It seems the error is the same:
This seems like a long problem to debug. In my experience, it is better to debug it first in local. @daviddavo would you have time to take a look? |
Yeah, I can try and give it some time next week |
I can't install lightfm on Python 3.12, this affects recommenders too |
Forked the repository and made a PR The package can be installed from my repository:
If the pull requests wasn't approved, I can transfer ownership of this repository to recommenders-team, and then that github repository could be used in the requirements. |
Signed-off-by: David Davó <david@ddavo.me>
By changing temporarily changing the requirements, it works on my machine. Let's see if it works on the test groups |
The following command works on my machine:
But perhaps my system comes with some build dependencies that are not installed in the test groups... Tomorrow I'll try and use conda to install the package on my machine and see how it goes |
Description
Related Issues
#2097
References
Checklist:
git commit -s -m "your commit message"
.staging branch
AND NOT TOmain branch
.