Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify gSSP docs for runtime #65962

Merged
merged 1 commit into from
May 20, 2024
Merged

docs: clarify gSSP docs for runtime #65962

merged 1 commit into from
May 20, 2024

Conversation

leerob
Copy link
Member

@leerob leerob commented May 20, 2024

Replaces #65948.

@leerob leerob requested review from a team as code owners May 20, 2024 01:02
@leerob leerob requested review from molebox and StephDietz and removed request for a team May 20, 2024 01:02
@ijjk ijjk added created-by: Next.js DevEx team Documentation Related to Next.js' official documentation. labels May 20, 2024
@joulev
Copy link
Contributor

joulev commented May 20, 2024

I think the edge runtime should still be mentioned, just that it is experimental. For people who host on Cloudflare Pages and similar platforms, they must use the edge runtime even when it is experimental, so it is probably better that they know they can still do that with the Pages Router.

@leerob
Copy link
Member Author

leerob commented May 20, 2024

We don't have a hard and fast rule on documenting experimental features, but most of the time we do not. We could probably get more clarity on that. Further, we don't recommend using edge rendering, as we've now seen through many customers it can be slower than Node.js based rendering and a degraded DX having to juggle between two runtimes. While edge rendering was never made stable in the Pages Router, it is a stable option in the App Router. However, I would still recommend only using the edge runtime for Middleware and not for rendering.

@leerob leerob merged commit a142012 into canary May 20, 2024
34 checks passed
@leerob leerob deleted the leerob-patch-2 branch May 20, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js DevEx team Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants