-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic switches for tplink #117758
Dynamic switches for tplink #117758
Conversation
Hey there @TheGardenMonkey, @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
5a633b5
to
bd05eb5
Compare
This is necessary as CoordinatedTPLinkEntity checks for parent to decide whether to use identifiers or connections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a merge conflict.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
* Inline entity filter * Allow entity classes to pass legacy unique_id handling as parameter
Adds primary entities to the parent device for devices such as power strips and wall switches.
…factoring later on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
p = PropertyMock(side_effect=KasaException) | ||
type(light_module).color_temp = p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid using single char variable names outside of a simple genexpr or comprehension
p = PropertyMock(side_effect=KasaException) | ||
type(light_module).color_temp = p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please avoid using single char variable names outside of a simple genexpr or comprehension
This PR is (the first) part of the tplink rewrite series, to be merged into
tplink_rewrite
branch (see #111151).Proposed change
switch
platform to use the new facilities.via_device
.TBD:
Documentation update (if it's not better done prior merging the dev branch back to master?)The screenshot below shows two new entities, and one that was previously hardcoded:
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: